[tor-commits] [tor/master] Update check-spaces to remove false positive for timercmp macro

[arma@xxxxxxxxxxxxxx]

commit 11221d0f17bf3ea6039249ad8b06b3a1afd6291d
Author: Sebastian Hahn <sebastian@xxxxxxxxxxxxxx>
Date:   Thu Nov 24 09:24:59 2011 +0100

    Update check-spaces to remove false positive for timercmp macro
    
    The timercmp macro uses triggers a "space between function name and
    opening parentheses" warning for the check spaces script. Work around
    this by simply disabling the check for all "functions" named 'op()'.
---
 changes/checkSpaces   |    5 +++++
 contrib/checkSpace.pl |    2 +-
 2 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/changes/checkSpaces b/changes/checkSpaces
new file mode 100644
index 0000000..91f79ed
--- /dev/null
+++ b/changes/checkSpaces
@@ -0,0 +1,5 @@
+   o Minor bugfixes:
+     - Prevent a false positive from the check-spaces script by disabling
+       the "whitespace between function name and (" check for functions
+       named 'op()'.
+
diff --git a/contrib/checkSpace.pl b/contrib/checkSpace.pl
index 6eb32e5..a18df99 100755
--- a/contrib/checkSpace.pl
+++ b/contrib/checkSpace.pl
@@ -97,7 +97,7 @@ for $fn (@ARGV) {
                 if ($1 ne "if" and $1 ne "while" and $1 ne "for" and
                     $1 ne "switch" and $1 ne "return" and $1 ne "int" and
                     $1 ne "elsif" and $1 ne "WINAPI" and $2 ne "WINAPI" and
-                    $1 ne "void" and $1 ne "__attribute__") {
+                    $1 ne "void" and $1 ne "__attribute__" and $1 ne "op") {
                     print "     fn ():$fn:$.\n";
                 }
             }

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits