[tor-commits] [tor/master] Resolve a resource leak in test_util_split_lines

[nickm@xxxxxxxxxxxxxx]

commit e83862a0ff7be42f5cbcb35c20b0405ca5bb27fd
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Wed Nov 30 12:16:08 2011 -0500

    Resolve a resource leak in test_util_split_lines
    
    Fixes coverity CID # 488
---
 src/test/test_util.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/test/test_util.c b/src/test/test_util.c
index 93f11cd..c762a8d 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -1660,7 +1660,7 @@ test_util_split_lines(void *ptr)
 
   int i, j;
   char *orig_line;
-  smartlist_t *sl;
+  smartlist_t *sl=NULL;
 
   (void)ptr;
 
@@ -1689,10 +1689,12 @@ test_util_split_lines(void *ptr)
     tt_assert(tests[i].split_line[j] == NULL);
     tor_free(orig_line);
     smartlist_free(sl);
+    sl = NULL;
   }
 
  done:
-  ;
+  tor_free(orig_line);
+  smartlist_free(sl);
 }
 
 static void



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits