[tor-commits] [tor/master] Remove needless fd var from test. CID 1130989.

[nickm@xxxxxxxxxxxxxx]

commit 6f7eb7a0a535a287fdb838d83e7ff9c7aac6fd6c
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Fri Nov 22 12:16:17 2013 -0500

    Remove needless fd var from test. CID 1130989.
---
 src/test/test_util.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/src/test/test_util.c b/src/test/test_util.c
index ab5928f..376e3aa 100644
--- a/src/test/test_util.c
+++ b/src/test/test_util.c
@@ -112,7 +112,6 @@ test_util_write_chunks_to_file(void *arg)
   char *tempname = NULL;
   char *str = NULL;
   int r;
-  int fd = -1;
   struct stat st;
 
   /* These should be two different sizes to ensure the data is different
@@ -155,7 +154,6 @@ test_util_write_chunks_to_file(void *arg)
   tt_int_op(st.st_size, ==, data_str_len);
   test_mem_op(data_str, ==, str, data_str_len);
   tor_free(str);
-  close(fd);
 
   // assert that the tempfile is removed (should not leave artifacts)
   str = read_file_to_str(tempname, RFTS_BIN|RFTS_IGNORE_MISSING, &st);
@@ -187,7 +185,6 @@ test_util_write_chunks_to_file(void *arg)
   tt_int_op(st.st_size, ==, data_str_len);
   test_mem_op(data_str, ==, str, data_str_len);
   tor_free(str);
-  close(fd);
 
   // assert the tempfile still contains the known string
   str = read_file_to_str(tempname, RFTS_BIN, &st);
@@ -204,8 +201,6 @@ test_util_write_chunks_to_file(void *arg)
   tor_free(str);
   tor_free(data_str);
   tor_free(temp_str);
-  if (fd >= 0)
-    close(fd);
 }
 
 static void



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits