[tor-commits] [tor/master] Fix a likely bug found by coverity in test_scheduler.c.

[nickm@xxxxxxxxxxxxxx]

commit 49976fabc4457713347fe6d0c8e16939de852393
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Thu Nov 27 23:21:46 2014 -0500

    Fix a likely bug found by coverity in test_scheduler.c.
    
    Andrea, do you agree with this?
    
    This is CID 1256186
---
 src/test/test_scheduler.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/test/test_scheduler.c b/src/test/test_scheduler.c
index da5c4e8..d031214 100644
--- a/src/test/test_scheduler.c
+++ b/src/test/test_scheduler.c
@@ -258,7 +258,7 @@ circuitmux_compare_muxes_mock(circuitmux_t *cmux_1,
     else if (cmux_1 == mock_ccm_tgt_2 && cmux_2 == mock_ccm_tgt_1) {
       result = 1;
     } else {
-      if (cmux_1 == mock_ccm_tgt_1 || cmux_1 == mock_ccm_tgt_1) result = -1;
+      if (cmux_1 == mock_ccm_tgt_1 || cmux_1 == mock_ccm_tgt_2) result = -1;
       else if (cmux_2 == mock_ccm_tgt_1 || cmux_2 == mock_ccm_tgt_2) {
         result = 1;
       } else {

_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits