[tor-commits] [tor/release-0.3.2] sched: Ignore closed channel after flushing cells

[nickm@xxxxxxxxxxxxxx]

commit dcabf801e52a83e2c3cc23ccc1fa906582a927d6
Author: David Goulet <dgoulet@xxxxxxxxxxxxxx>
Date:   Wed Nov 8 09:44:39 2017 -0500

    sched: Ignore closed channel after flushing cells
    
    The flush cells process can close a channel if the connection write fails but
    still return that it flushed at least one cell. This is due because the error
    is not propagated up the call stack so there is no way of knowing if the flush
    actually was successful or not.
    
    Because this would require an important refactoring touching multiple
    subsystems, this patch is a bandaid to avoid the KIST scheduler to handle
    closed channel in its loop.
    
    Bandaid on #23751.
    
    Signed-off-by: David Goulet <dgoulet@xxxxxxxxxxxxxx>
---
 changes/bug23751        | 6 ++++++
 src/or/scheduler_kist.c | 9 +++++++++
 2 files changed, 15 insertions(+)

diff --git a/changes/bug23751 b/changes/bug23751
new file mode 100644
index 000000000..2fd702166
--- /dev/null
+++ b/changes/bug23751
@@ -0,0 +1,6 @@
+  o Minor bugfixes (scheduler, channel):
+    - Ignore channels that have been closed while flushing cells. This can
+      happen if the write on the connection fails leading to the channel being
+      closed while in the scheduler loop. This is not a complete fix, it is a
+      bandaid until we are able to refactor those interactions. Fixes bug
+      23751; bugfix on 0.3.2.1-alpha.
diff --git a/src/or/scheduler_kist.c b/src/or/scheduler_kist.c
index a3b74e8cc..d1726ba34 100644
--- a/src/or/scheduler_kist.c
+++ b/src/or/scheduler_kist.c
@@ -598,6 +598,15 @@ kist_scheduler_run(void)
     if (socket_can_write(&socket_table, chan)) {
       /* flush to channel queue/outbuf */
       flush_result = (int)channel_flush_some_cells(chan, 1); // 1 for num cells
+      /* XXX: While flushing cells, it is possible that the connection write
+       * fails leading to the channel to be closed which triggers a release
+       * and free its entry in the socket table. And because of a engineering
+       * design issue, the error is not propagated back so we don't get an
+       * error at this poin. So before we continue, make sure the channel is
+       * open and if not just ignore it. See #23751. */
+      if (!CHANNEL_IS_OPEN(chan)) {
+        continue;
+      }
       /* flush_result has the # cells flushed */
       if (flush_result > 0) {
         update_socket_written(&socket_table, chan, flush_result *



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits