[tor-commits] [tor/master] remove confusing comment about conditional consensus download

[nickm@xxxxxxxxxxxxxx]

commit 9228db5f1bee0b715b73ba6f8c11f5eb77d59f62
Author: Roger Dingledine <arma@xxxxxxxxxxxxxx>
Date:   Sun Oct 2 19:13:35 2016 -0400

    remove confusing comment about conditional consensus download
    
    We removed that feature in 0.2.4.2-alpha, but some comments seem to
    have lingered.
    
    I didn't add a changes/ file since this is just internal code cleanup.
---
 src/or/directory.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/or/directory.c b/src/or/directory.c
index 52b14b9..1f894d9 100644
--- a/src/or/directory.c
+++ b/src/or/directory.c
@@ -495,9 +495,6 @@ MOCK_IMPL(void, directory_get_from_dirserver, (
        * sort of dir fetch we'll be doing, so it won't return a bridge
        * that can't answer our question.
        */
-      /* XXX+++++ Not all bridges handle conditional consensus downloading,
-       * so, for now, never assume the server supports that. -PP
-       * Is that assumption still so in 2016? -NM */
       const node_t *node = choose_random_dirguard(type);
       if (node && node->ri) {
         /* every bridge has a routerinfo. */
@@ -1305,9 +1302,9 @@ compare_strs_(const void **a, const void **b)
 
 /** Return the URL we should use for a consensus download.
  *
- * This url depends on whether or not the server we go to
- * is sufficiently new to support conditional consensus downloading,
- * i.e. GET .../consensus/<b>fpr</b>+<b>fpr</b>+<b>fpr</b>
+ * Use the "conditional consensus downloading" feature described in
+ * dir-spec.txt, i.e.
+ * GET .../consensus/<b>fpr</b>+<b>fpr</b>+<b>fpr</b>
  *
  * If 'resource' is provided, it is the name of a consensus flavor to request.
  */



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits