[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

[tor-commits] [Git][tpo/applications/tor-browser][base-browser-115.3.1esr-13.0-1] fixup! Bug 40926: Implemented the New Identity feature

Title: GitLab

ma1 pushed to branch base-browser-115.3.1esr-13.0-1 at The Tor Project / Applications / Tor Browser

Commits:

  • b5574131
    by hackademix at 2023-10-05T19:03:10+02:00 
    fixup! Bug 40926: Implemented the New Identity feature

Bug 41765: Force about:privatebrowsing in new identity window.

2 changed files:

Changes:

  • browser/base/content/browser.js
    ... ... @@ -4521,7 +4521,7 @@ function OpenBrowserWindow(options) {
    4521 4521 
       var extraFeatures = "";
    4522 4522 
       if (options && options.private && PrivateBrowsingUtils.enabled) {
    4523 4523 
         extraFeatures = ",private";
    4524 
    -    if (!PrivateBrowsingUtils.permanentPrivateBrowsing) {
    4524 
    +    if (!PrivateBrowsingUtils.permanentPrivateBrowsing || options.private === "no-home") {
    4525 4525 
           // Force the new window to load about:privatebrowsing instead of the default home page
    4526 4526 
           defaultArgs = "about:privatebrowsing";
    4527 4527 
         }

  • browser/components/newidentity/content/newidentity.js
    ... ... @@ -433,11 +433,8 @@ XPCOMUtils.defineLazyGetter(this, "NewIdentityButton", () => {
    433 433 
         openNewWindow() {
    434 434 
           logger.info("Opening a new window");
    435 435 
           return new Promise(resolve => {
    436 
    -        // Open a new window with the default homepage
    437 
    -        // We could pass {private: true} but we do not because we enforce
    438 
    -        // browser.privatebrowsing.autostart = true.
    439 
    -        // What about users that change settings?
    440 
    -        const win = OpenBrowserWindow();
    436 
    +        // Open a new window forcing the about:privatebrowsing page (tor-browser#41765)
    437 
    +        const win = OpenBrowserWindow({private: "no-home"});
    441 438 
             // This mechanism to know when the new window is ready is used by
    442 439 
             // OpenBrowserWindow itself (see its definition in browser.js).
    443 440 
             win.addEventListener("MozAfterPaint", () => resolve(), { once: true });

    • —
    View it on GitLab.
    You're receiving this email because of your account on gitlab.torproject.org. Manage all notifications · Help 

    _______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits