[tor-commits] [obfsproxy/master] Remove a conditional that's guaranteed to be false and causes Apple's gcc to barf

[nickm@xxxxxxxxxxxxxx]

commit 19eda9f86a92e4f8e849e6669a11f2b3beab29e7
Author: Zack Weinberg <zackw@xxxxxxxxx>
Date:   Thu Aug 4 14:49:56 2011 -0700

    Remove a conditional that's guaranteed to be false and causes Apple's gcc to barf
---
 src/socks.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/src/socks.c b/src/socks.c
index 9941005..46bc5d5 100644
--- a/src/socks.c
+++ b/src/socks.c
@@ -317,12 +317,6 @@ socks5_handle_negotiation(struct evbuffer *source,
 
   evbuffer_drain(source, 1);
 
-  /* this should be impossible, but we check it anyway for great defensiveness */
-  if (nmethods > 0xFF) {
-    log_warn("too many methods!");
-    return SOCKS_BROKEN;
-  }
-
   if (evbuffer_remove(source, methods, nmethods) < 0)
     obfs_abort();
 



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits