[tor-commits] [tor/master] Disable a single pbkdf2 test vector

[nickm@xxxxxxxxxxxxxx]

commit 7c521096410b23f234d299e344efe879ceae7643
Author: Nick Mathewson <nickm@xxxxxxxxxxxxxx>
Date:   Fri Sep 9 09:57:15 2016 -0400

    Disable a single pbkdf2 test vector
    
    The other test vectors are pretty complete, and get full coverage, I
    believe.
    
    This one test vector accounted for half the time spent in
    test-slow.  "Now that's slow!"
---
 src/test/test_crypto_slow.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/test/test_crypto_slow.c b/src/test/test_crypto_slow.c
index 26b3d40..0d7d65a 100644
--- a/src/test/test_crypto_slow.c
+++ b/src/test/test_crypto_slow.c
@@ -421,12 +421,16 @@ test_crypto_pbkdf2_vectors(void *arg)
             secret_to_key_compute_key(out, 20, spec, 5, "password", 8, 1));
   test_memeq_hex(out, "4b007901b765489abead49d926f721d065a429c1");
 
+  /* This is the very slow one here.  When enabled, it accounts for roughly
+   * half the time spent in test-slow. */
+  /*
   base16_decode((char*)spec, sizeof(spec),
                 "73616c74" "18" , 10);
   memset(out, 0x00, sizeof(out));
   tt_int_op(20, OP_EQ,
             secret_to_key_compute_key(out, 20, spec, 5, "password", 8, 1));
   test_memeq_hex(out, "eefe3d61cd4da4e4e9945b3d6ba2158c2634e984");
+  */
 
   base16_decode((char*)spec, sizeof(spec),
                 "73616c7453414c5473616c7453414c5473616c745"



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits