[tor-commits] [tor/master] hs: Improve comments for when we change timestamps

[nickm@xxxxxxxxxxxxxx]

commit 1749e078914db58850d6dc932ceab78970ae8be6
Author: David Goulet <dgoulet@xxxxxxxxxxxxxx>
Date:   Thu Sep 21 14:24:36 2017 -0400

    hs: Improve comments for when we change timestamps
    
    Signed-off-by: David Goulet <dgoulet@xxxxxxxxxxxxxx>
---
 src/or/hs_client.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/or/hs_client.c b/src/or/hs_client.c
index 77fbf548e..a02175929 100644
--- a/src/or/hs_client.c
+++ b/src/or/hs_client.c
@@ -1185,8 +1185,10 @@ hs_client_desc_has_arrived(const hs_ident_dir_conn_t *ident)
 
     log_info(LD_REND, "Descriptor has arrived. Launching circuits.");
 
-    /* Restart their timeout values, so they get a fair shake at connecting to
-     * the hidden service. XXX: Improve comment on why this is needed. */
+    /* Because the connection can now proceed to opening circuit and
+     * ultimately connect to the service, reset those timestamp so the
+     * connection is considered "fresh" and can continue without being closed
+     * too early. */
     base_conn->timestamp_created = now;
     base_conn->timestamp_lastread = now;
     base_conn->timestamp_lastwritten = now;



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits