[tor-commits] [tor/master] test: Use SEVERITY_MASK_IDX() to find the LOG_* mask indexes

[asn@xxxxxxxxxxxxxx]

commit d30a042fa8348028e0bea6f3e46cba1ffbe5adcc
Author: teor <teor@xxxxxxxxxxxxxx>
Date:   Wed Sep 25 16:35:02 2019 +1000

    test: Use SEVERITY_MASK_IDX() to find the LOG_* mask indexes
    
    In the unit tests and fuzzers.
    
    Fixes bug 31334; bugfix on 0.2.5.2-alpha.
---
 changes/bug31334               | 4 ++++
 src/test/fuzz/fuzzing_common.c | 2 +-
 src/test/test_logging.c        | 2 +-
 src/test/test_options.c        | 6 +++---
 src/test/testing_common.c      | 4 ++--
 5 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/changes/bug31334 b/changes/bug31334
new file mode 100644
index 000000000..dfc9cc530
--- /dev/null
+++ b/changes/bug31334
@@ -0,0 +1,4 @@
+  o Code simplification and refactoring:
+    - Use SEVERITY_MASK_IDX() to find the LOG_* mask indexes in the unit
+      tests and fuzzers, rather than using hard-coded values.
+      Closes ticket 31334.
diff --git a/src/test/fuzz/fuzzing_common.c b/src/test/fuzz/fuzzing_common.c
index 862acb2b3..e269c36b4 100644
--- a/src/test/fuzz/fuzzing_common.c
+++ b/src/test/fuzz/fuzzing_common.c
@@ -167,7 +167,7 @@ main(int argc, char **argv)
     memset(&s, 0, sizeof(s));
     set_log_severity_config(loglevel, LOG_ERR, &s);
     /* ALWAYS log bug warnings. */
-    s.masks[LOG_WARN-LOG_ERR] |= LD_BUG;
+    s.masks[SEVERITY_MASK_IDX(LOG_WARN)] |= LD_BUG;
     add_stream_log(&s, "", fileno(stdout));
   }
 
diff --git a/src/test/test_logging.c b/src/test/test_logging.c
index bb7018fe1..203ce64e3 100644
--- a/src/test/test_logging.c
+++ b/src/test/test_logging.c
@@ -35,7 +35,7 @@ test_get_sigsafe_err_fds(void *arg)
 
   set_log_severity_config(LOG_WARN, LOG_ERR, &include_bug);
   set_log_severity_config(LOG_WARN, LOG_ERR, &no_bug);
-  no_bug.masks[0] &= ~(LD_BUG|LD_GENERAL);
+  no_bug.masks[SEVERITY_MASK_IDX(LOG_ERR)] &= ~(LD_BUG|LD_GENERAL);
   set_log_severity_config(LOG_INFO, LOG_NOTICE, &no_bug2);
 
   /* Add some logs; make sure the output is as expected. */
diff --git a/src/test/test_options.c b/src/test/test_options.c
index 0747a2e06..b3654ede7 100644
--- a/src/test/test_options.c
+++ b/src/test/test_options.c
@@ -54,9 +54,9 @@ setup_log_callback(void)
 {
   log_severity_list_t lst;
   memset(&lst, 0, sizeof(lst));
-  lst.masks[LOG_ERR - LOG_ERR] = ~0;
-  lst.masks[LOG_WARN - LOG_ERR] = ~0;
-  lst.masks[LOG_NOTICE - LOG_ERR] = ~0;
+  lst.masks[SEVERITY_MASK_IDX(LOG_ERR)] = ~0;
+  lst.masks[SEVERITY_MASK_IDX(LOG_WARN)] = ~0;
+  lst.masks[SEVERITY_MASK_IDX(LOG_NOTICE)] = ~0;
   add_callback_log(&lst, log_cback);
   mark_logs_temp();
 }
diff --git a/src/test/testing_common.c b/src/test/testing_common.c
index ad22898ce..9e7d83dcd 100644
--- a/src/test/testing_common.c
+++ b/src/test/testing_common.c
@@ -295,7 +295,7 @@ main(int c, const char **v)
     memset(&s, 0, sizeof(s));
     set_log_severity_config(loglevel, LOG_ERR, &s);
     /* ALWAYS log bug warnings. */
-    s.masks[LOG_WARN-LOG_ERR] |= LD_BUG;
+    s.masks[SEVERITY_MASK_IDX(LOG_WARN)] |= LD_BUG;
     add_stream_log(&s, "", fileno(stdout));
   }
   {
@@ -303,7 +303,7 @@ main(int c, const char **v)
     log_severity_list_t s;
     memset(&s, 0, sizeof(s));
     set_log_severity_config(LOG_ERR, LOG_ERR, &s);
-    s.masks[LOG_WARN-LOG_ERR] |= LD_BUG;
+    s.masks[SEVERITY_MASK_IDX(LOG_WARN)] |= LD_BUG;
     add_callback_log(&s, log_callback_failure);
   }
   flush_log_messages_from_startup();



_______________________________________________
tor-commits mailing list
tor-commits@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-commits