[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [PATCH] contrib/tor-exit-notice.html url fix
Hi Christian,
thanks for your patch. Comments below:
On Feb 21, 2010, at 4:30 AM, Christian Kujau wrote:
> Hi,
>
> just a minor URL fix to the contrib/tor-exit-notice.html document. Also
> adding a DOCTYPE to make it valid XHTML.
Simply adding the doctype won't make something valid xhtml. The file is
far from being valid, so we should fix that first before declaring our
compliance.
> Apart from these nitpicks, the latest -git checkouts are running great on
> Linux/powerpc!
Great to hear, thanks!
> Thanks,
> Christian.
>
> diff --git a/tor-exit-notice.orig.html b/tor-exit-notice.html
> index 4ab028f..dbbf031 100644
> --- a/tor-exit-notice.orig.html
> +++ b/tor-exit-notice.html
> @@ -1,4 +1,7 @@
> -<html>
> +<?xml version="1.0"?>
> +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
> + "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd";>
> +<html xmlns="http://www.w3.org/1999/xhtml";>
> <head>
> <title>This is a Tor Exit Router</title>
>
dropping this hunk, see comment above
> [snip]
> <p>You also have the option of blocking this IP address and others on
> the Tor network if you so desire. The Tor project provides a <a
> -href="https://tor-svn.freehaven.net/svn/tor/trunk/contrib/exitlist";>python script</a> to
> +href="https://check.torproject.org/cgi-bin/TorBulkExitList.py";>python script</a> to
> extract all IP addresses of Tor exit nodes, and an official <a
> href="https://www.torproject.org/tordnsel/";>DNSRBL</a> is also available to
> determine if a given IP address is actually a Tor exit server. Please
I added some more words here to hopefully make it clear what we mean.
Generally, please feel free to send git format-patch formatted patches, if you want
(or I'm happy to make commits from diffs, if that is what you prefer).
Please let me know if this patch works for you, and whether you want a different
kind of credit.
http://gitweb.torproject.org//sebastian/tor.git?a=commitdiff;h=29fd31cf6b85dc54b4623c460c6aaeadb21281f1
If you want to submit a patch to make the exit notice file actually xhtml compliant,
that'd be neat, too. We've been going with the "fewer bytes" maxime here so far,
though.
Sincere thanks for your efforts!
Sebastian