On Fri, 14 Feb 2014 16:43:00 +0100
Fabian Keil <freebsd-listen@xxxxxxxxxxxxx> wrote:
> Yawning Angel <yawning@xxxxxxxxxxxxxxx> wrote:
> It's already fixed in 1e25c55ba54 without the patch.
Yay.
> > On a side note, tip of tree requires updating liballium since I
> > switched both of liballium and obfsclient to
> > auto[conf/make]/libtool. Hopefully the build process is less rage
> > inducing now.
>
> It is for me. With the attached patches it builds on FreeBSD.
I'll merge them, thanks!
> The "#if 0" patch is just FYI, I'm sure a better solution is
> possible, but it wasn't immediately obvious to me what the
> pragmas are good for.
Hmm. It should have suppressed the warning that caused build failure,
but since my use of gtest never uses those, I'll just go with "#if 0"ing
it out.
> ./obfsclient_test dumps core:
> Core was generated by `obfsclient_test'.
> Program terminated with signal 10, Bus error.
> #0 0x00000000004090c6 in
> schwanenlied::crypto::Ctr<schwanenlied::crypto::AesEcb<&EVP_aes_128_ecb,
> 16ul> >::process (this=0x7fffffffd4f8, buf=0x433c31
> 16ul> ><schwanenlied::crypto::AesTest_CtrAes128_SP800_38A_Test::TestBody()::vectors+1>
> 16ul> >"\301\276\342.@\237\226\351=~\021s\223\027*\207Ma\221\266
> 16ul> >\343&\033\357hd\231\r\266\316\256-\212W\036\003\254\234\236\267o\254E\257\216Q\230\006\366kyp\375\377\206\027\030{\271\377\375\377\060\310\034F\243\\\344\021\345\373\301\031\032\nR\357Z\344\337>\333\325\323^[O\t\002\r\260>\253\366\237$E\337O\233\027\255+A{\346l7\020\036\003\035\332/\276\003\321y!p\240\363",
> 16ul> >len=<optimized out>, out=<optimized out>)
> 16ul> >at ./src/schwanenlied/crypto/ctr.h:165 165 *out++
> 16ul> >= (*buf++)^ block_[offset_];
> (gdb) p offset_
> $1 = 11330806256049838041
What the. Ok. I'll look at that, though it is a "this should never
happen" sort of situation. I think I'll end up setting up a FreeBSD VM
since my FreeBSD box is on 9.1p10.
> I didn't look into this or test obfsclient yet, but intend
> to do so in the next couple of days.
If the test case is failing, it will probably dump core unfortunately.
I'll look into it as well.
Thanks for the assistance and patches!
--
Yawning Angel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ tor-dev mailing list tor-dev@xxxxxxxxxxxxxxxxxxxx https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev