On Sun, Jun 17, 2007 at 04:43:48PM +0100, Robert Hogan wrote: > On Sunday 17 June 2007 16:13:28 Nick Mathewson wrote: > > On Sun, Jun 17, 2007 at 02:14:21PM +0100, Robert Hogan wrote: > > [...] > > > > > Hi Nick, > > > > > > That's a much better idea. Patch attached. The extension format in the > > > control-spec hasn't been implemented yet (so far as I can tell) so I've > > > gone along with the current method. Am I right on this? If so, would you > > > like someone to do it? > > > > Applied; looks ok. (The extension format in control-spec _is_ the one > > that's implemented in control.c, as far as I can tell. Am I missing > > something?) > > > > Reading the spec, I expected to see 'setevents extended' produce something > like: > > 650-CIRC 1000 EXTENDED moria1,moria2 0xBEEF > 650-EXTRAMAGIC=99 > 650 ANONYMITY=high > > rather than > > 650 CIRC 1000 EXTENDED moria1,moria2 0xBEEF EXTRAMAGIC=99 ANONYMITY=high > > Closer reading shows that both should be expected. Haven't checked > the code to see if both formats are implemented. But will do. We only generate the second format right now, IIRC. If you want to do a patch for something, I wouldn't mind one to clarify how the format works. :) peace, -- Nick Mathewson
Attachment:
pgpw9nwQ0Kiyl.pgp
Description: PGP signature