[tor-dev] [PATCH] remove test for remote SOCKS Port at config validation

[Martin Kepplinger <martink@xxxxxxxxx>]

(why doesn't git send-email work for this list?)

this is UNTESTED and for now, more of a question if this may suffice to
close ticket 4019:

-- 
Martin Kepplinger
http://martinkepplinger.com

From 8fe174008e162bff7eb5a15e5f34cc6731e852dd Mon Sep 17 00:00:00 2001
From: Martin Kepplinger <martink@xxxxxxxxx>
Date: Sat, 28 Jun 2014 14:24:52 +0200
Subject: [PATCH] remove test for remote SOCKS Port at config validation

remove the check for a non-local SOCKS Port in the config by removing
the flag when calling parse_port_config() for it.

this should only prevent parse_port_config() from writing a warning
that is written when the listener is opened anyways, according to
https://trac.torproject.org/projects/tor/ticket/4019
---
this is UNTESTED and more of a question if that may suffice for closing
ticket 4019 for now.

 src/or/config.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/or/config.c b/src/or/config.c
index 10df839..7c22171 100644
--- a/src/or/config.c
+++ b/src/or/config.c
@@ -6002,8 +6002,7 @@ parse_ports(or_options_t *options, int validate_only,
              options->SocksPort_lines, options->SocksListenAddress,
              "Socks", CONN_TYPE_AP_LISTENER,
              "127.0.0.1", 9050,
-             CL_PORT_WARN_NONLOCAL|CL_PORT_ALLOW_EXTRA_LISTENADDR|
-             CL_PORT_TAKES_HOSTNAMES) < 0) {
+             CL_PORT_ALLOW_EXTRA_LISTENADDR|CL_PORT_TAKES_HOSTNAMES) < 0) {
     *msg = tor_strdup("Invalid SocksPort/SocksListenAddress configuration");
     goto err;
   }
-- 
1.7.10.4

_______________________________________________
tor-dev mailing list
tor-dev@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev