Hi, On 5 May 2019, at 07:02, Steve Snyder <swsnyder@xxxxxxxxxxxxx> wrote: > On 5/4/19 12:26 PM, David Fifield wrote: >> On Sat, May 04, 2019 at 03:27:53PM +0000, Yawning Angel wrote: >>> On 5/3/19 1:48 PM, Steve Snyder wrote: >>>> FYI, obfs4proxy no longer recognizes address:port in this form: >>>> >>>> ServerTransportListenAddr obfs4 [000.000.000.000]:443 >>>> >>>> Note the square brackets. Tor 0.3.5.8 / 0.4.0.5 still parses this >>>> syntax, and obfs4proxy used to too. As of 0.0.10 it no longer does. >>> >>> Odd. None of that code, both in obfs4proxy and goptlib, has changed for >>> years. I'll look at it when I have a moment. >> >> Might be this? >> >> tor_addr_parse is overly permissive >> https://bugs.torproject.org/23082 > > Well, if that was supposed be a general fix then bug 23082 wasn't fixed > very well. ORPort is still OK with the square bracket syntax while > ServerTransportListenAddr is not. You're right: tor's internal lookup function has a similar bug, which we didn't fix in 23082. Tor uses separate functions for IP address parsing and hostname lookups, and they handle IPv4 addresses in square brackets differently. I opened a ticket for this issue, and submitted a fix which uses the same address parser on all IP addresses: https://trac.torproject.org/projects/tor/ticket/30721 We won't backport this fix, because it changes config parsing. So it will probably end up in tor 0.4.2.1-alpha and later. T
Attachment:
signature.asc
Description: Message signed with OpenPGP
_______________________________________________ tor-dev mailing list tor-dev@xxxxxxxxxxxxxxxxxxxx https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev