[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [or-cvs] r14216: Only log a notice that dmalloc has been set up if it fails. (in tor/trunk: . src/or)



nickm@xxxxxxxx wrote:

> Author: nickm
> Date: 2008-03-27 12:46:39 -0400 (Thu, 27 Mar 2008)
> New Revision: 14216

> Log:
>  r19093@catbus:  nickm | 2008-03-27 12:43:58 -0400
>  Only log a notice that dmalloc has been set up if it fails.  Actually,
> since we have not added a temp log yet, I am not sure this ever does
> anything.
 
> Modified: tor/trunk/src/or/main.c
> ===================================================================
> --- tor/trunk/src/or/main.c	2008-03-27 16:46:36 UTC (rev 14215)
> +++ tor/trunk/src/or/main.c	2008-03-27 16:46:39 UTC (rev 14216)
> @@ -1969,7 +1969,8 @@
>  #ifdef USE_DMALLOC
>    int r = CRYPTO_set_mem_ex_functions(_tor_malloc, _tor_realloc,
>                                        _tor_dmalloc_free);
> -  log_notice(LD_CONFIG, "Set up dmalloc; returned %d", r);
> +  if (!r) {
> +    log_warn("Couldn't configure openssl to use dmalloc functions.");
>  #endif
>  #ifdef NT_SERVICE
>    {

I might be missing the bigger picture here,
but the opening curly brace looks lonely to me.

Fabian

Attachment: signature.asc
Description: PGP signature