[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-dev] Patch to remove goto from sandbox.c
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Hi,
> See <https://www.kernel.org/doc/Documentation/CodingStyle>, Chapter 7,
> “Centralized exiting of functions” for a rationale.
I saw some functions where the idea above seems fitting. But there had also
been some code parts, like this from the sandbox, where it didn't made any
sense to me.
Like in the lines 1012, 1055, 1098 and 1138 of sandbox.c where we could just
also use a break statement to leave the while loops.
For the lines 1273, 1278, 1284, 1290 and 1296 of sandbox.c I could
understand the use of goto, although it would also work with "else if" very
well.
It had been just an idea to improve the code base, although only from my
point of view as it seems :)
Then I just keep reading the source code to understand it and somtimes also
contribute to it, I hope.
bye
Hartmut
- --
Ideas are the only things that can change the world.
The rest is details. -- Scott Adams
https://netzpolitik.org/2013/anleitung-so-verschlusselt-ihr-eure-e-mails-mit-pgp/
new Key ID since 26.07.13: 0xD8C361E6
Fingerprint: E5B3 302B 1BE1 D0B4 F190 E739 A365 60A9 D8C3 61E6
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAEBAwAGBQJTEimgAAoJEKNlYKnYw2HmuVkQALezNtRJKgtFVyjMV/BeO94t
vi4DSNwlcFwEJ3r5aKfm9Pr0DemqwWDf1AfyZx/wUf7ffehfDtQzuReKk/7vqd/E
E0VvbhHdGBMu0KqUyLRt2z4+Vc0gsvdkQ38iBb5XdlE0cqImVDSSa+WI350MkOQN
KPnKqzxeqmRz2Wqxag1wmDr5RecYMEn6XQpL2QvkjWEfJAVWVh5b1rH73gkorhK6
vr7kCSOpPCYJvZKDb1XJj4XMVO45DcjxtKZ84WfZRULZ8lBpBMO0bymtg7E8/Qi0
kh7VApUsB8tJg7ZlKeMq3k1zHIouIQDn77bVADKqmPG6l105ysBAJypA6Tr3PrhX
1H0j8+ryuxN49bQ9EXZ8RGzghKQtVA+mp/IS7nIrMh9rV+8gMQYrvw9RlZeMiOQy
jWyhsObZGHoCwo11sF3b/423ej0vrdyXjteUXdSbUUwOrBhxy65FQAqvX1AvxMXp
N0FjRQNmO1SXvLkeWCnVeuKMwPQ7NneOjrVwdw1XdfvImeWt9GL1J8956tzlsYuZ
UMFcNMneiF1Fbcuc8O4MpOg8DGdTXP3ZwzvJZsihAdWHN0LLJELj+9z8+Gy5wEl4
8ipAKJEQEEmjhlLjc18p5d8IssIrUQKzQ2b5VRfC3NaeOMxtjcwtrtdA1sIzFC+C
91/Pr4WaAnzpMVS2aM+B
=xFDE
-----END PGP SIGNATURE-----
_______________________________________________
tor-dev mailing list
tor-dev@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev