[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: Stream starvation in Tor (with patch)

To: or-dev@xxxxxxxxxxxxx
Subject: Re: Stream starvation in Tor (with patch)
From: Nick Mathewson <nickm@xxxxxxxxxxxxx>
Date: Mon, 22 Nov 2010 10:49:53 -0500
Cc: Mashael AlSabah <malsabah@xxxxxxxxxxxxxxx>, Damon Mccoy <dlmccoy@xxxxxxxxxxx>, Kevin Bauer <ksbauer@xxxxxxxxx>
Delivered-to: archiver@xxxxxxxx
Delivered-to: or-dev-outgoing@xxxxxxxx
Delivered-to: or-dev@xxxxxxxx
Delivery-date: Mon, 22 Nov 2010 10:50:00 -0500
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type; bh=mPKdKGvCUejOW+Vzw3wbKB/BarZtbHq1DTQHqBusTyA=; b=JdNSfJVVqOjSsIy028uWIbK29e9wFMr5svuPPVsxu0LDtgWvQ/QgnuA6QUSTIqY4Gu WJXN8o7I6w7pWnEspl9Xj03b6jvsmTLWuLUyqdaYQqiWNGv+AXDcNlPSO7D6OkcX1yhg w+2S+U7DWWqRpOXH5IW/xKjBqjw8oZ8Zhqhiw=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=CVBlk0FfO6kvmWfw7j857bQOXWBiKh2o0K/UGOBuggkPfAcGn5L5CaEHN9MPS9W+tN uGIyG6Hp2Gh2EfyN6gm+g/GqwNjjX1X8ER4Xgh+LfT4pTCAmLErnGuA26/AkLmsdm359 xX2ZobhXg1xPDEhY16m6TWPoiRIVLbA8muroM=
In-reply-to: <20101122133315.GA22741@xxxxxxxxxxxxxxxxxxxxx>
References: <20101122133315.GA22741@xxxxxxxxxxxxxxxxxxxxx>
Reply-to: or-dev@xxxxxxxxxxxxx
Sender: owner-or-dev@xxxxxxxxxxxxx

On Mon, Nov 22, 2010 at 8:33 AM, Ian Goldberg <iang@xxxxxxxxxxxxxxx> wrote:
[...]
> The patch is attached.

Looks good to me, & thanks for the hard work. I think it should go
into 0.2.2.x, with a possible backport to 0.2.1.x as a followup to
#1653.

I've added a ticket for this as
https://trac.torproject.org/projects/tor/ticket/2210#comment:3  .
Without a trac ticket, we tend to lose track of patches.  I've posted
a quick code review there too.

peace,
-- 
Nick

References:
- Stream starvation in Tor (with patch)
  - From: Ian Goldberg

Prev by Author: Next developer party Tuesday, Nov 23 at 1pm EST (18:00 UTC)
Next by Author: Re: Thoughts on https://trac.torproject.org/projects/tor/wiki/dev/SupportPolicy
Previous by thread: Stream starvation in Tor (with patch)
Next by thread: Thoughts on https://trac.torproject.org/projects/tor/wiki/dev/SupportPolicy
Index(es):
- Author
- Thread