Re: [tor-dev] [Patch] tools\tor-fw-helper\tor-fw-helper-natpmp.c

Subject: Re: [tor-dev] [Patch] tools\tor-fw-helper\tor-fw-helper-natpmp.c

From: Nick Mathewson <nickm@xxxxxxxxxxxx>

Date: Thu, 1 Nov 2012 13:37:33 -0400

Delivery-date: Thu, 01 Nov 2012 13:37:43 -0400

Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=JVJeAJyR+s/IGWXYXDnJbNjMRzbilSUm4+1hY7ZFf/o=; b=oxfSCgsOSdh4ZIzLKpLmQF8aewVukqy9Zm3xbABXhbEgIR8iJXbmlNaPvIvhr1DTDz nJWYUIps3dJHU6o/PWTvaz7XKUcmoPSZCMOnUoe4gWVhZj677eadVGkGBNrJO5rn10A3 48P/YS+iNNZJLqOw8cLBQ7VLOGi6/2pLvSHTi014JFHI3p+C0yNo9OJSDY9jmU8tHEjq mhNghN1W8Kd+Gl/nCLYino36axRkb+rv8qPrycGNSU0v1O6TjGlA6E1uv2SvqWyNEIs4 rXQsjgo6nhwYXf986xo+aBSP7eumFw6VmEMyjdcVc0/xFA0mQCYvkigR2qNN1hPxiQQN aCSA==

In-reply-to: <D11D91A25ADE47DBAFA33359E833E86E@xxxxxxxx>

List-archive: <http://lists.torproject.org/pipermail/tor-dev>

List-help: <mailto:tor-dev-request@lists.torproject.org?subject=help>

List-id: discussion regarding Tor development <tor-dev.lists.torproject.org>

List-post: <mailto:tor-dev@lists.torproject.org>

List-subscribe: <https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev>, <mailto:tor-dev-request@lists.torproject.org?subject=subscribe>

List-unsubscribe: <https://lists.torproject.org/cgi-bin/mailman/options/tor-dev>, <mailto:tor-dev-request@lists.torproject.org?subject=unsubscribe>

References: <D11D91A25ADE47DBAFA33359E833E86E@xxxxxxxx>

Reply-to: tor-dev@xxxxxxxxxxxxxxxxxxxx

Sender: tor-dev-bounces@xxxxxxxxxxxxxxxxxxxx

The code in tools\tor-fw-helper\tor-fw-helper-natpmp.c does
things wrong on Winsock where e.g. errno isn't set on socket-errors and 'fd' is (always?) >= FD_SETSIZE. Patch attached.

Thanks. I've copied this information to the bugtracker as bug 7280 ( https://trac.torproject.org/projects/tor/ticket/7280 ).

best wishes,

Nick

_______________________________________________ tor-dev mailing list tor-dev@xxxxxxxxxxxxxxxxxxxx https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-dev