[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: : Export END_CIRC_REASON_* to controler



Thus spake Nick Mathewson (nickm@xxxxxxxxxxxxx):

> > 1. If the circuit path is empty, there's a double space between
> > FAILED/CLOSED and the REASON. Not sure how to best handle this. I
> > tweaked my regex to work with single or double space (I think), so
> > it doesn't matter to me, but it is sort of contrary to the spec.
> 
> Thanks; fixed.  (I hope; please try it out.)

Ok, just saw an event for it. It looks good now.


> Probably, we should define more reasons; see some of the comments I
> did for the patch in r8672 for other reasons that don't match up with
> what the spec seems to say.

Actually, do you want me to do this?


-- 
Mike Perry
Mad Computer Scientist
fscked.org evil labs