[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [patch] server status getinfos

On Sat, Sep 08, 2007 at 07:32:35PM +0100, Robert Hogan wrote:
> Adds getinfo:
>     "status/good-server-descriptor"
>     "status/or-reachability-succeeded"
>     "status/dir-reachability-succeeded"

This part is good.

> and splits out the REACHABILITY_SUCCEEDED event into:

> This makes sense because it maintains the one-to-one relationship between 
> getinfo requests and status-events, getinfo reachability-succeeded would be 
> too ambiguous to be useful, and makes writing controllers simpler because it 
> is easier to identify the meaning of a status event by the 'action' of *all* 
> status events rather than, in special cases, a combination of the action and 
> one or more of the arguments.

Yes, but we need to think about backward compatibility!  Any program
which previously worked by looking for REACHABILITY_SUCCEEDED (which
has been shipped in the stable 0.1.2.x series) would break if we split
it like this.  It is not okay to change events around to break old
programs, when we can avoid this.

There's a pretty easy fix.  How about if the events become:

         0 or 1.
         0 or 1
         "OR=" ("0"/"1") SP "DIR=" ("0"/"1") ?

and the REACHABILITY_SUCCEEDED events remain as-is?  Unless you
object, I'll rewrite the patch to do this instead.

Nick Mathewson

Attachment: pgpa6XbxKhjma.pgp
Description: PGP signature