Re: unable to submit bug report

[Scott Bennett <bennett@xxxxxxxxxx>]

     On Fri, 5 Jun 2009 19:44:45 -0400 Nick Mathewson <nickm@xxxxxxxxxxxxxx>
wrote:
>Thank you so much for the stack traces!  I have found a bug that I

    You're welcome, of course.  And I thank you for taking a look at it so
quickly!

>think might have caused this.  (It's a little hard to tell for sure,
>because a bunch of functions got inlined.)  Can you try this patch

     I suppose I should have mentioned that I always build it with
CFLAGS="-march=prescott" on the configure command, which ought to alter
some of what -O2 does during the compilations.

>(also uploaded to flyspray)?
>
>
>diff --git a/src/or/policies.c b/src/or/policies.c
>index cb914d1..d55e86c 100644
>--- a/src/or/policies.c
>+++ b/src/or/policies.c
>@@ -411,6 +411,7 @@ load_policy_from_option(config_line_t *config,
>smartlist_t **policy,
>         memcpy(&newp, n, sizeof(newp));
>         newp.prt_min = 1;
>         newp.prt_max = 65535;
>+        newp.is_canonical = 0;
>         c = addr_policy_get_canonical_entry(&newp);
>         SMARTLIST_REPLACE_CURRENT(*policy, n, c);
>         addr_policy_free(n);
>
     0.2.1.14-rc is running at the moment, but my intention was to switch over
to 0.2.1.15-rc the next time tor goes down.  I took a look at policies.c and
found the spot.  patch(1) didn't like the above, saying,

patch: **** malformed patch at line 4: smartlist_t **policy,

but I can certainly insert the additional line by hand.  One moment...hmm...
yes, it looks like it built okay.  I'll go ahead and install it, so it will
run the next time tor starts.
     I'd prefer to try to let tor stay up a few days before bringing it down
again in hopes of retaining the Stable flag it has at present.  I'm already a
bit surprised that it still has the Stable flag, given how many times it has
gone down in the last several days (3 times, IIRC).  Have to keep the uptime
averages up there, you know. :-)  OTOH, I don't dare give it a SIGHUP for any
reason right now, so waiting may wear thin soon.  We'll see.
>
>(Also, when we next switch bugtrackers, we should probably switch to
>one with an email gateway that works.)
>
     That would be helpful, yes.
     Thanks again for getting to this so fast and, with a bit of luck, fixing
it, too.


                                  Scott Bennett, Comm. ASMELG, CFIAG
**********************************************************************
* Internet:       bennett at cs.niu.edu                              *
*--------------------------------------------------------------------*
* "A well regulated and disciplined militia, is at all times a good  *
* objection to the introduction of that bane of all free governments *
* -- a standing army."                                               *
*    -- Gov. John Hancock, New York Journal, 28 January 1790         *
**********************************************************************