[tor-talk] torsocks logic

[Isidor Zeuner <onions@xxxxxxxxxxx>]

Hi there,

there seems to be some discrepancy in torsocks' logic, at least
since August 2016.

In "src/common/utils.c", check_addr returns -1 for non-AF addresses.

So does utils_is_address_ipv4 as it just passes check_addr's
return value.

However, in "src/lib/gethostbyname.c", tsocks_gethostbyname expects
the return value to be a C boolean, so the -1 value from above is
treated as a positive result.

I guess one of the three functions may better be adjusted in order to
ensure more effective operation.

Best regards,

Isidor Zeuner

This e-mail and its attachments may contain confidential and/or
legally privileged information. Any unauthorised copying, disclosure,
dissemination or distribution of the material in this e-mail is
strictly prohibited.
--
tor-talk mailing list - tor-talk@xxxxxxxxxxxxxxxxxxxx
To unsubscribe or change other settings go to
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-talk