Re: [pygame] Pygame Mixer Crackle noise not an SDL_Mixer problem

[Lenard Lindstrom <len-l@xxxxxxxxx>]

I did (revision 1222). Pygame is back to sounding like its old self (1.7).

Lenard


Quoting René Dudfield <renesd@xxxxxxxxx>:

> ah,
> 
> feel free to change that back... I mistakenly added the extra
> brackets, thinking I was cleaning it up - when I was adding the bug
> fix for reverse stereo in 8bit.  I should have just left that part
> alone.
> 
> ...
> 
> But strangely we were having the crackling sound problem way before I
> made that change (about one month ago).
> 
> 
> 
> 
> On Thu, Apr 24, 2008 at 12:24 PM, Lenard Lindstrom <len-l@xxxxxxxxx> wrote:
> > Beat Nicholas. It is revision 1143 (need 1146 to compile) that breaks
> things.
> >  It deals with an SDL_mixer bug where the stereo channels are reversed for
> 8 bit
> >  sound. I wonder if this is our culprit:
> >
> >  ==== From around line 160 in mixer.c ===============
> >      /*make chunk a power of 2*/
> >      for (i = 0; 1 << i < chunk; ++i); //yes, semicolon on for loop
> >      chunk = MAX (1 << i, 256);
> >  ==== To around line 167 ============================
> >      /*make chunk a power of 2*/
> >      for (i = 0; 1 << i < chunk; ++i) {
> >      chunk = MAX (1 << i, 256);
> >      }
> >