[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [pygame] Py_BEGIN_ALLOW_THREADS in surface.c

To: pygame-users@xxxxxxxx
Subject: Re: [pygame] Py_BEGIN_ALLOW_THREADS in surface.c
From: René Dudfield <renesd@xxxxxxxxx>
Date: Thu, 4 Apr 2013 11:58:16 +0200
Delivered-to: archiver@xxxxxxxx
Delivered-to: pygame-users-outgoing@xxxxxxxx
Delivered-to: pygame-users@xxxxxxxx
Delivery-date: Thu, 04 Apr 2013 05:58:24 -0400
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=B0QyREyIht58Uegfj+J8k3z/Set/eom5ImQL0fBwaZA=; b=OhxOZUJi0qUjw32jIIKKhDvD1usX8InJkQdo5+WnwjxSKCnOjUbdJd6w/D1hbJQCPj 6/qYiox+sIjXtf28YEEayQtuJmk3mxOWKJlAfAXfi7MBP/ikQITNoEjwwNOSoVsz2hhO BIL8C6+povwZYty3SKeAmZ1QgJtxy93GhPqvqPLzLxxXzWQ6bJfIaPAUxCP7qI/m1PSH s9nOJ4WCRNYCtmAeir3tKzA2uuLWC0B+mByE+hQyqGIdfSVnJp06hmkvADHtpbcKPkHh PSBGjMJjOR/8EXXC2DAmmH0WTpiVUzwINQibqZ4Qleddf9I33+Dg17aKgt0WRZwy3ks8 b/DA==
In-reply-to: <CANdAuzcWEr8V=HDO6kgLOfuuEY5G_uZZoLc9X6uPnN8Ux7wbPQ@xxxxxxxxxxxxxx>
References: <CANdAuzcWEr8V=HDO6kgLOfuuEY5G_uZZoLc9X6uPnN8Ux7wbPQ@xxxxxxxxxxxxxx>
Reply-to: pygame-users@xxxxxxxx
Sender: owner-pygame-users@xxxxxxxx

On Thu, Apr 4, 2013 at 7:33 AM, Tom Rothamel <tom@xxxxxxxxxxx> wrote:

I'm curious - why are Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS commented out (and otherwise missing) in surface.c? It seems like those would be the most expensive functions, and hence the ones that would benefit most from running in a threaded environment.

They're used in many other parts of pygame.

They don't work there in some situations... which I can't remember off the top of my head right now. By don't work, I mean it causes things to crash.

References:
- [pygame] Py_BEGIN_ALLOW_THREADS in surface.c
  - From: Tom Rothamel

Next by Author: Re: [pygame] Request for participation in GSOC13 under PSF
Previous by thread: [pygame] Py_BEGIN_ALLOW_THREADS in surface.c
Next by thread: [pygame] BUG: reproducible hard hang (i.e. SIGKILL only) in pygame!
Index(es):
- Author
- Thread