[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: Functions that steal references (Re: [pygame] [patch] minor memory leaks...)

To: pygame-users@xxxxxxxx
Subject: Re: Functions that steal references (Re: [pygame] [patch] minor memory leaks...)
From: Tyler Laing <trinioler@xxxxxxxxx>
Date: Tue, 16 Jun 2009 17:45:23 -0700
Delivered-to: archiver@xxxxxxxx
Delivered-to: pygame-users-outgoing@xxxxxxxx
Delivered-to: pygame-users@xxxxxxxx
Delivery-date: Tue, 16 Jun 2009 20:52:06 -0400
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=b/VHOY6lDSQVV5AZVWrWYC/gn3jl0ezwAlODSFEdq1E=; b=HHMO6vcZqn8rQ9KD51AZkL7ZyTL6n4URhw4lFCusJunyCwloPyVOurHVfh+oRauB9o Hc3kC4m+swt+EAl3mn9AbJBro2m4CuSwVBUnJ49UVHAK7vExEzYqWIaiD9dRy4flE3T7 as1NHxJ+W8TV0f7jJTlrzx7JCabSBMFCc1R+Q=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=dxyMcZWyooV4Cww35iOT+0BJQPnLft3d64oz/0E2G0H4LxShk2O898iJMx+sSz3Mj1 lMxcffbOvViv8ZGcTKwGdGLpycpyl756+ztf0yTOUcO91yc0iqM5BANAK58W3otivBDn Wl6NqyUrjOb7nVC9oap6nksBj1eHfu6/oJOFg=
In-reply-to: <4A383A2B.90208@xxxxxxxxxxxxxxxx>
References: <4A36AF6C.2000503@xxxxxxxxxxxxxxxxx> <4A36F1EE.9040704@xxxxxxxxx> <4A382505.8010101@xxxxxxxxxxxxxxxx> <4A382DC6.8090407@xxxxxxxxx> <4A383A2B.90208@xxxxxxxxxxxxxxxx>
Reply-to: pygame-users@xxxxxxxx
Sender: owner-pygame-users@xxxxxxxx

Bring it up with python-core then. They at the least should have a consistent failure condition. Unless things have gone HORRENDOUSLY wrong at which point its better to just shut down than to deal with the error.

-Tyler

On Tue, Jun 16, 2009 at 5:34 PM, Greg Ewing <greg.ewing@xxxxxxxxxxxxxxxx> wrote:

Lenard Lindstrom wrote:

What a function that steals a reference does with an error is undocumented. PyModule_AddObject only steals a referenece when it succeeds. PyList_SetItem and PyTuple_SetItem always steals a reference. The only way to find out which is the case is to examine the Python source code.

Well, that's pretty unsatisfactory. The refcounting
behaviour on failure is just as important as any
other part of the function's spec, and needs to
be documented somewhere.

--
Greg

--
Visit my blog at http://oddco.ca/zeroth/zblog

References:
- [pygame] [patch] minor memory leaks in color.c, font.c, mask.c and pixelarray.c
  - From: Lorenz Quack
- Re: [pygame] [patch] minor memory leaks in color.c, font.c, mask.c and pixelarray.c
  - From: Lenard Lindstrom
- Functions that steal references (Re: [pygame] [patch] minor memory leaks...)
  - From: Greg Ewing
- Re: Functions that steal references (Re: [pygame] [patch] minor memory leaks...)
  - From: Lenard Lindstrom
- Re: Functions that steal references (Re: [pygame] [patch] minor memory leaks...)
  - From: Greg Ewing

Prev by Author: [pygame] Using sdl_surface for the movie module
Next by Author: Re: [pygame] Color, unpacking to r,g,b and r,g,b,a - ValueError: too many values to unpack
Previous by thread: Re: Functions that steal references (Re: [pygame] [patch] minor memory leaks...)
Next by thread: Re: Functions that steal references (Re: [pygame] [patch] minor memory leaks...)
Index(es):
- Author
- Thread