[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [pygame] PATCH: pyportmidi object de-allocation error (and fix)

To: pygame-users@xxxxxxxx
Subject: Re: [pygame] PATCH: pyportmidi object de-allocation error (and fix)
From: René Dudfield <renesd@xxxxxxxxx>
Date: Thu, 3 Mar 2011 23:38:36 +0000
Delivered-to: archiver@xxxxxxxx
Delivered-to: pygame-users-outgoing@xxxxxxxx
Delivered-to: pygame-users@xxxxxxxx
Delivery-date: Thu, 03 Mar 2011 18:38:42 -0500
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=aI8WJe84UFkN4qTjYr+daAaW10CQg7At8P3cOXP+c/A=; b=TAgJusEcG+VOHrbnqsVtABpavzRFPtMmtAiMuyvt+RgWnVx5826VA59H6ZDkQ0UKAe cOHAUJW1RoMJlRjZS5AGUUMVQRiTZ0aNh+L1xWti4f+hnctM6U6rvTaCAuS96YicEGOJ tQmhWTU/fdnG557McVs/8KhUx+mlzL6rqaDFM=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=OGLITnjPdwzSZpMwrJfjF3mw0lf3glUYN4fKSF7d+Ule4FuyM4nwL2Q7Gkz6UdfCZg 2Xn1Pqz8sk47kZsPTQZjHD/haQDwSOil6wmqnC7pb2h6j1hTLP1O24Ohl7V2mDC5/HfW vk4/fYiIY/9cI8GjH0z9xWvfVh9j128CMPWX8=
In-reply-to: <4D701302.3000604@xxxxxxxxxxxxx>
References: <4D67EEC9.4050701@xxxxxxxxxxxxx> <AANLkTimg6JJtQ0pFeEG1=ztvvSNbdv4WFGBQoTBWgCMf@xxxxxxxxxxxxxx> <4D693D0C.5090301@xxxxxxxxxxxxx> <4D701302.3000604@xxxxxxxxxxxxx>
Reply-to: pygame-users@xxxxxxxx
Sender: owner-pygame-users@xxxxxxxx

Hey ya,

looks like a lot of good work.

I'll do a review tomorrow tomorrow morning (in 8 hours or so), then check it in.

Have you tried it with the pygame.examples.midi input and output?

I don't have my midi equipment with me, so I'll only be able to do tests with out it.

cya!

On Thu, Mar 3, 2011 at 10:15 PM, Christopher Arndt <chris@xxxxxxxxxxxxx> wrote:

Christopher Arndt schrieb:
> René Dudfield schrieb:

>> I will review them and apply them
>> to both the pygame repo, and the portmidi repo. The python bindings now
>> live with portmidi, so no need to send them to the bitbucket page.
>
> Ok, so I'm attaching my second patch here as well.

Any thoughts on my patches, anyone?

Chris

Follow-Ups:
- Re: [pygame] PATCH: pyportmidi object de-allocation error (and fix)
  - From: Christopher Arndt

References:
- Re: [pygame] PATCH: pyportmidi object de-allocation error (and fix)
  - From: Christopher Arndt

Prev by Author: Re: [pygame] Inconsistency in online docs
Next by Author: Re: [pygame] Using reStructuredText for document sources
Previous by thread: Re: [pygame] PATCH: pyportmidi object de-allocation error (and fix)
Next by thread: Re: [pygame] PATCH: pyportmidi object de-allocation error (and fix)
Index(es):
- Author
- Thread