Re: [tor-bugs] #2835 [Vidalia]: Vidalia âFind Bridges Nowâ button doesn't work

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#2835: Vidalia âFind Bridges Nowâ button doesn't work
---------------------+------------------------------------------------------
 Reporter:  rransom  |          Owner:  chiiph      
     Type:  defect   |         Status:  needs_review
 Priority:  major    |      Milestone:              
Component:  Vidalia  |        Version:              
 Keywords:           |         Parent:              
   Points:           |   Actualpoints:              
---------------------+------------------------------------------------------

Comment(by edmanm):

 Ah, yeah, I was going to take a look at this and then forgot. Sorry. But,
 yes, you want to add the right CA certificate, not Tor's certificate.
 That's why I said "including the proper CA certificate" above, named the
 function `loadDefaultCaCertificates()`, use
 `QSslSocket::addDefaultCaCertificates()`, etc. :-)

 In any case, that patch sure doesn't look right to me. You're adding the
 certificates to the default list of CA certificates like this:

 {{{
 +  if (! QSslSocket::addDefaultCaCertificates(":/pki/DigiCertCA.crt"))
 +    vWarn("Failed to add the DigiCert Global CA certificate to the
 default CA "
 +          "certificate database.");
 +  if (! QSslSocket::addDefaultCaCertificates(":/pki/DigiCertCA2.crt"))
 +    vWarn("Failed to add the DigiCert Assured CA certificate to the
 default CA "
 +          "certificate database.");
 +  if (! QSslSocket::addDefaultCaCertificates(":/pki/DigiCertCA3.crt"))
 +    vWarn("Failed to add the DigiCert High Assurance CA certificate to
 the default CA "
 +          "certificate database.");
 }}}

 But you're adding them to the .qrc like this:

 {{{
 +    <file>DigiCertCA.crt</file>
 +    <file>DigiCertAssuredCA.crt</file>
 +    <file>DigiCertHighAssuranceCA.crt</file>
 }}}

 The second two DigiCert CA certificates you're trying to add in
 `Vidalia::loadDefaultCaCertificates()` won't get added since you're
 specifying the wrong filenames. The first one will, though, so if that's
 all that's needed then why are you trying to add the other two CA
 certificates?

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2835#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs