[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #4971 [Tor Client]: Provide initvalue in GETINFO config/names
#4971: Provide initvalue in GETINFO config/names
-------------------------+--------------------------------------------------
Reporter: chiiph | Owner:
Type: enhancement | Status: needs_revision
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
-------------------------+--------------------------------------------------
Comment(by rransom):
Replying to [comment:6 atagar]:
> > Does anything else parse the output of GETINFO config/names?
>
> Yup, arm does.
>
https://gitweb.torproject.org/arm.git/blob/HEAD:/src/cli/configPanel.py#l213
>
https://gitweb.torproject.org/arm.git/blob/HEAD:/src/util/torConfig.py#l182
>
https://gitweb.torproject.org/arm.git/blob/HEAD:/src/util/torConfig.py#l359
>
https://gitweb.torproject.org/arm.git/blob/HEAD:/src/util/torInterpretor.py#l317
>
> I don't mind changing it, so please reassign this ticket to me after a
tor patch is merged.
No. Any arm change should have a separate ticket.
> > Does control-spec.txt specify its output format?
>
> Yes it does.
> https://gitweb.torproject.org/torspec.git/blob/HEAD:/control-
spec.txt#l610
>
> I don't like the idea of the initial value being at the end since it
would then make this...
>
> OptionName SP OptionType [ SP Documentation ][ SP InitialValue ] CRLF
>
> Multiple optional arguments, especially when the first is defined as
'Text', means that controllers can't differentiate Documentation from the
InitialValue. We could redefine the Documentation's Text type as not
having quotes but from a parsing perspective... ewww.
No version of Tor will support both Documentation and InitialValue. If
Documentation was removed in Tor 0.2.2.x, arm (and other controllers)
should simply drop support for it.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4971#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs