Re: [tor-bugs] #5346 [Tor Client]: parse_http_time is borked

["Tor Bug Tracker & Wiki" <torproject-admin@xxxxxxxxxxxxxx>]

#5346: parse_http_time is borked
------------------------+---------------------------------------------------
 Reporter:  nickm       |          Owner:                    
     Type:  defect      |         Status:  needs_revision    
 Priority:  normal      |      Milestone:  Tor: 0.2.2.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------
Changes (by nickm):

  * status:  needs_review => needs_revision


Comment:

 > I'm making a branch here with a fix

 Not seeing the fix.

 >So, what about using gmtime?

 It would be okay by me.

 > Also, in parse_http_time(), we don't set tm_wkday. I wonder if we
 should?

 I think we're in the clear so long as we don't use it, and document that
 we don't set it.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5346#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs