[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #5095 [Tor Client]: Setting __ReloadTorrcOnSIGHUP=0 breaks logrotate

#5095: Setting __ReloadTorrcOnSIGHUP=0 breaks logrotate
------------------------+---------------------------------------------------
 Reporter:  arma        |          Owner:                    
     Type:  defect      |         Status:  needs_review      
 Priority:  normal      |      Milestone:  Tor: 0.2.3.x-final
Component:  Tor Client  |        Version:                    
 Keywords:              |         Parent:                    
   Points:              |   Actualpoints:                    
------------------------+---------------------------------------------------

Comment(by arma):

 1) char *msg; wants to be char *msg = NULL; yes?

 2)
 {{{
 -  if (old_options) {
 +  if (old_options && old_options != global_options) {
 }}}
 is just an optimization, since option_is_same() will be true at each step,
 yes? (It's fine as an optimization; I just want to make sure I'm not
 missing something deeper.)

 Looks fine other than that (I think -- it definitely needs some testing
 too).

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5095#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs