[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #1667 [Tor Client]: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP request on the control port

#1667: Give a more appropriate "I'm not an HTTP proxy" message when we get an HTTP
request on the control port
----------------------------+-----------------------------------------------
    Reporter:  nickm        |       Owner:  neena           
        Type:  enhancement  |      Status:  needs_review    
    Priority:  trivial      |   Milestone:  Tor: unspecified
   Component:  Tor Client   |     Version:                  
  Resolution:               |    Keywords:  easy            
      Parent:               |      Points:                  
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by neena):

  * status:  needs_revision => needs_review


Comment:

 Replying to [comment:16 nickm]:
 > Hm. Actually, the strcmpstart() stuff in the last couple of commits
 isn't right yet.  strcmpstart can fail if it gets something other than a
 NUL-terminated string, and neither buf->data nor the output of
 inspect_evbuffer() is guaranteed to be NUL-terminated.  Also, if you want
 N characters from inspect_evbuffer, you need to tell it to give you N
 characters: right now, it is only guaranteed to give one character.

 Fixed. I think.

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/1667#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs