[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #2731 [Vidalia]: Relay panel could benefit from more optional columns

#2731: Relay panel could benefit from more optional columns
-------------------------+--------------------------------------------------
 Reporter:  chiiph       |          Owner:  sirop       
     Type:  enhancement  |         Status:  needs_review
 Priority:  minor        |      Milestone:              
Component:  Vidalia      |        Version:              
 Keywords:               |         Parent:              
   Points:               |   Actualpoints:              
-------------------------+--------------------------------------------------
Changes (by sirop):

  * status:  needs_revision => needs_review


Comment:

 https://github.com/sirop/vidalia_0.3.2_alpha/commit/a02b347af69b0322972b4f0694b75236bfd2e3c1

 1.

 {{{
                  tb->setToolButtonStyle(Qt::ToolButtonTextBesideIcon);
  176     214       ui.horizontalLayout->addWidget(tb);
  177            -
          215    +
  178     216       /* Restore the state of each splitter */
 }}}

 This new line is added/removed due to double white space that was there
 before.

 2. Sorting IPs:

 {{{
 /** Convert IP numbers to quint64 for the comparison operator
  * filling the dot separated groups with zeroes if necessary.
  */
 quint64
 RouterListItem::iptoquint64(const RouterListItem *ListItem) const
 {
   bool ok;
   quint64 a_IPnumber;
   QString a_IPString;
   a_IPString = ListItem->descriptor().ip().toString();
   QStringList ListIP = a_IPString.split(".", QString::SkipEmptyParts);
   a_IPString = "";
   for (int i = ListIP.size()-1; i >= 1; i--) {
   ListIP[i] = ListIP[i].rightJustified(3, '0');
   a_IPString.prepend(ListIP[i]);
   }
   a_IPString.prepend(ListIP[0]);
   a_IPnumber = a_IPString.toULongLong(&ok, 10);
   return(a_IPnumber);
 }
 }}}

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/2731#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs