[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #5674 [Obfsproxy]: Add --with-libevent-dir and --with-openssl-dir args, instead of using env. vars.
#5674: Add --with-libevent-dir and --with-openssl-dir args, instead of using env.
vars.
-----------------------+----------------------------------------------------
Reporter: asn | Owner: asn
Type: defect | Status: new
Priority: normal | Milestone:
Component: Obfsproxy | Version:
Keywords: building | Parent:
Points: | Actualpoints:
-----------------------+----------------------------------------------------
Comment(by asn):
The `{libcrypto,libevent}_{LIBS,CFLAGS}` environment variables of
obfsproxy seem to do the same thing as `--with-{foo}-dir`. That is, if the
user sets them, `pkg-config` is not queried and obfsproxy's build system
trusts them blindly:
{{{
if test -n "$libevent_CFLAGS"; then
pkg_cv_libevent_CFLAGS="$libevent_CFLAGS"
elif test -n "$PKG_CONFIG"; then
if test -n "$PKG_CONFIG" && \
{ { $as_echo "$as_me:${as_lineno-$LINENO}: \$PKG_CONFIG --exists
--print-errors \"libevent >= 2.0\""; } >&5
($PKG_CONFIG --exists --print-errors "libevent >= 2.0") 2>&5
ac_status=$?
$as_echo "$as_me:${as_lineno-$LINENO}: \$? = $ac_status" >&5
test $ac_status = 0; }; then
pkg_cv_libevent_CFLAGS=`$PKG_CONFIG --cflags "libevent >= 2.0"
2>/dev/null`
else
pkg_failed=yes
fi
else
pkg_failed=untried
fi
}}}
I was thinking that `--with-{foo}-dir` arguments would simply replace the
process of setting env. vars and make it more user friendly and easy to
understand.
I was considering these solutions as the only way to complete the
installation if `pkg-config` fails us.
Any ideas on how `pkg-config` can help us here, nickm?
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/5674#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs