[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #4019 [Tor Client]: Tor warns about public SocksPort addresses twice on startup
#4019: Tor warns about public SocksPort addresses twice on startup
------------------------+---------------------------------------------------
Reporter: rransom | Owner: tomfitzhenry
Type: defect | Status: assigned
Priority: normal | Milestone: Tor: 0.2.3.x-final
Component: Tor Client | Version:
Keywords: | Parent:
Points: | Actualpoints:
------------------------+---------------------------------------------------
Changes (by tomfitzhenry):
* status: needs_review => assigned
Comment:
An important point is that this change has an unexpected side-effect.
Prior to this change: When validating the config file (in
parse_port_config), warn_nonlocal_controller_ports() was called, which
would remove unauthenticated non-local ControlPorts from 'ports'.
parse_port_config() then returns to parse_port(). At the end of
parse_port(), n_ports_out is set to the number of ports. This number would
not include the unauthenticated non-local ControlPort.
After this change: When validating the config file (in parse_port_config),
warn_nonlocal_controller_ports() would not be called. Thus n_ports_out
/would/ include the unauthenticated non-local ControlPort.
I will see if there is a way to preserve old behaviour, and if not,
whether n_ports_out's value changing will cause any issues (there are
various corner cases related to value of FooListenAddress).
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/4019#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs