[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8235 [Tor]: pathbias_count_build_success()

#8235: pathbias_count_build_success()
----------------------------+-----------------------------------------------
    Reporter:  cypherpunks  |       Owner:  mikeperry                  
        Type:  defect       |      Status:  needs_revision             
    Priority:  major        |   Milestone:  Tor: 0.2.4.x-final         
   Component:  Tor          |     Version:  Tor: 0.2.4.10-alpha        
  Resolution:               |    Keywords:  tor-client, MikePerry201304
      Parent:               |      Points:                             
Actualpoints:               |  
----------------------------+-----------------------------------------------
Changes (by andrea):

  * status:  needs_review => needs_revision


Comment:

 Begin code review:

  * 2e1dd2d9d0ab11160ab6c45e6923551b50717027 looks fine to me
  * In c29da58ecb58f6513a4a3051144b285bb3653f3e, you're emitting log
 message if the counts become inconsistent after scaling but were
 consistent before (counts_are_sane && ...); if !counts_are_sane, are we
 certain to have already warned when that condition first occurred, or can
 this cause it to silently not log?  Change this or say you're sure this is
 the case, I think.
  * 585c3108e6bddcc7a42750129cfc2392adf7e27c looks okay
  * 1afbe225eca4aaf21be1b60d7fc8204d628c28d6 looks okay

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8235#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs