[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
[tor-bugs] #8639 [Tor]: Controller: Stream event source field is "<unknown address type>:1" for DNS requests from the controller
#8639: Controller: Stream event source field is "<unknown address type>:1" for DNS
requests from the controller
--------------------+-------------------------------------------------------
Reporter: Desoxy | Owner:
Type: defect | Status: new
Priority: normal | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version: Tor: 0.2.4.11-alpha
Keywords: | Parent:
Points: | Actualpoints:
--------------------+-------------------------------------------------------
My patch #8203 tried to be clever and copied the IP and port of the
control connection into the SOURCE field of STREAM_EVENT_NEW_RESOLVE
events. As it turns out, the control connection address can be a unix
domain socket, which tor_dup_addr helpfully converts to "<unknown address
type>".
From the control Spec
{{{
Address = ip4-address / ip6-address / hostname (XXXX Define these)
(...)
"650" SP "STREAM" SP StreamID SP StreamStatus SP CircuitID SP Target
[SP "REASON=" Reason [ SP "REMOTE_REASON=" Reason ]]
[SP "SOURCE=" Source] [ SP "SOURCE_ADDR=" Address ":" Port ]
[SP "PURPOSE=" Purpose]
CRLF
}}}
Previously "(Tor_internal):0" was used, even though it also did not follow
the control spec, but the controllers seemed to handle it fine.
My suggestion: If the control connection is via a unix domain socket, use
"(Tor_internal)" again. And while we are at it, add (Tor_internal) to the
control spec as well.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8639>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs