[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8683 [Tor]: moria1 isn't voting for Fast flag when it should
#8683: moria1 isn't voting for Fast flag when it should
----------------------+-----------------------------------------------------
Reporter: arma | Owner:
Type: defect | Status: needs_review
Priority: blocker | Milestone: Tor: 0.2.4.x-final
Component: Tor | Version:
Keywords: tor-auth | Parent:
Points: | Actualpoints:
----------------------+-----------------------------------------------------
Comment(by arma):
Fun!
Here's my theory: we set node->is_exit while router_is_active is true, and
once router_is_active stops being true, we never change our opinion about
is_exit.
You would think that there would then be a subtle bug where the relay
changes its exit policy while staying unreachable, and then we'd
mistakenly keep voting Exit. But I think when the exit policy changes, the
node_t gets replaced with the new one, which starts out without the flags.
There *is* a different sort of subtle bug, where if we've never found a
relay reachable, we don't vote the Exit flag for it, even if its exit
policy warrants it. That happens for example when the directory authority
starts up.
I just checked, and now that moria1 has been running for a while, it is in
fact voting Exit-but-not-Running on some relays. So it looks like we have
retained the old behavior. (I'm not sure if that's counter to the goals of
#8435, since I don't know what those goals were.)
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8683#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs