[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #8631 [Stem]: Integ tests rename process

#8631: Integ tests rename process
-----------------------+----------------------------------------------------
    Reporter:  atagar  |       Owner:  atagar 
        Type:  defect  |      Status:  closed 
    Priority:  normal  |   Milestone:         
   Component:  Stem    |     Version:         
  Resolution:  fixed   |    Keywords:  testing
      Parent:          |      Points:         
Actualpoints:          |  
-----------------------+----------------------------------------------------
Changes (by atagar):

  * status:  needs_review => closed
  * resolution:  => fixed


Comment:

 Very nice catch! The str_tools module has methods for unicode/bytes
 conversions to better support python3 compatibility but strangely it
 doesn't work in this case. The call I tried was...

 {{{
 process_name_encoded = stem.util.str_tools._to_unicode(process_name)
 }}}

 ... which would functionally be the same as what you have, but with
 'replace' (rather than bulking at characters it can't convert)...

 {{{
 process_name_encoded = process_name.encode('utf8', 'replace')
 }}}

 But it didn't work. Oh well, I ran your patch with both python2 and
 python3 and they're both happy now so pushed.

 Thanks! -Damian

 PS. Minor nitpick but git has a specific format it expects commit messages
 to have. There's no need to state the modified files (that's easily seen
 from the commit), but it does expect...

 {{{
 Short summary line

 Description of stuff, preferably explaining the issue,
 your fix, the ticket url, testing done, etc...
 }}}

 http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html

 For instance I changed the commit message for this one to...

 https://gitweb.torproject.org/stem.git/commitdiff/8adc55c0139ff9f0925541be1254bea4767716ed

-- 
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8631#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs