[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #8440 [Ooni]: ooni: tls_handshake.py host and port options do not work
#8440: ooni: tls_handshake.py host and port options do not work
-----------------------+----------------------------------------------------
Reporter: isis | Owner: isis
Type: defect | Status: closed
Priority: normal | Milestone:
Component: Ooni | Version:
Resolution: fixed | Keywords: ooni, tls_handshake
Parent: | Points:
Actualpoints: |
-----------------------+----------------------------------------------------
Changes (by isis):
* status: new => closed
* resolution: => fixed
Comment:
The port option works as it should. And --host is broken, you're correct.
The ticket for adding this feature is #8366 and the bug for it not working
is #8440.
Ticket #8440 is fixed here:
{{{
* commit 044227d4f553ca4996a6c3e289c0df547025317b
| gpg: Signature made Mon 22 Apr 2013 00:35:02 UTC
gpg: using RSA key A3ADB67A2CDB8B35
gpg: Good signature from "Isis! <isis@xxxxxxxxxxxxxxxxxxxxx>"
gpg: aka "Isis <isis@xxxxxxxxxxxxxx>"
gpg: aka "Isis <isis@xxxxxxx>"
gpg: aka "Isis! <isis@xxxxxxxxxx>"
Author: Isis Lovecruft <isis@xxxxxxxxxxxxxx>
| AuthorDate: 12 minutes ago
| Commit: Isis Lovecruft <isis@xxxxxxxxxxxxxx>
| CommitDate: 12 minutes ago
|
| Fix #8440, set the self.host attribute when given the --host option.
|
| * Port option doesn't need to be fixed. It does what the option
help string
| always said it does (which is actually slightly confusing and
perhaps should
| be changed): it sets *all* the hosts' ports to --port. So, given
a file of
| host:ports and a '--host 1.2.3.4:4343' cmdline option, if also
given '--port
| 443', it will check every host, both in the file and the cmdline
directives,
| on port 443. This is useful for checking a specific port, like if
we wanted
| to check TLSv1 on the IMAPS (993) port for every host.
|
| nettests/experimental/tls_handshake.py | 19 ++++---------------
| 1 file changed, 4 insertions(+), 15 deletions(-)
|
}}}
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/8440#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs