[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15585 [Tor]: /src/util.c refactoring

#15585: /src/util.c refactoring
-----------------------------+------------------------------
     Reporter:  arcadiaq     |      Owner:  arcadiaq
         Type:  enhancement  |     Status:  assigned
     Priority:  normal       |  Milestone:
    Component:  Tor          |    Version:
   Resolution:               |   Keywords:  refactoring, Tor
Actual Points:               |  Parent ID:
       Points:               |
-----------------------------+------------------------------

Comment (by yawning):

 Hmm, there's nothing in the style guidelines forbidding this behavior, and
 leaving out braces for single line `if` statements is something done
 throughout the rest of the code, so I'm not seeing the point of this
 change.

 Since it's cosmetic and isn't something that's consistent with the rest of
 the codebase I'm inclined to NACK this.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15585#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs