[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15491 [Tor Browser]: Windows: silent failure if no permission to apply update

#15491: Windows: silent failure if no permission to apply update
-------------------------+-------------------------------------------------
     Reporter:  mcs      |      Owner:  mcs
         Type:  defect   |     Status:  closed
     Priority:  normal   |  Milestone:
    Component:  Tor      |    Version:
  Browser                |   Keywords:  firefox-patch, tbb-4.5-alpha,
   Resolution:  wontfix  |  TorBrowserTeam201504
Actual Points:           |  Parent ID:
       Points:           |
-------------------------+-------------------------------------------------
Changes (by mcs):

 * status:  new => closed
 * resolution:   => wontfix


Comment:

 Further analysis shows that the reason for the silent failure is that in
 our testing we changed Windows file permissions between the time a MAR
 file was downloaded and the time it was applied (that was the way we found
 to trigger the "runas" code that we removed for #15201).  Because
 _postUpdateProcessing() within nsUpdateService.js does a "canApplyUpdates"
 check, and because that check fails due to lack of write permission, the
 update is not applied.

 In the normal case where file permissions are not changed at an odd time,
 the failure is not silent.  If the user lacks permission to install an
 update but has write permission to their profile (so they can use the
 browser), a nice message that explains that they lack the system
 permissions required to install the update is displayed; see the
 manualUpdate.desc entity here:
   http://mxr.mozilla.org/mozilla-esr31/source/toolkit/locales/en-
 US/chrome/mozapps/update/updates.dtd#20

 Closing this bug as "wontfix" since, realistically, it won't occur in the
 real world.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15491#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs