[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15689 [Tor Browser]: Switch back to using the HTTPS-Everywhere git repository for Tor Browser builds

#15689: Switch back to using the HTTPS-Everywhere git repository for Tor Browser
builds
-------------------------+-------------------------------------------------
     Reporter:  gk       |      Owner:  gk
         Type:           |     Status:  needs_revision
  enhancement            |  Milestone:
     Priority:  normal   |    Version:
    Component:  Tor      |   Keywords:  tbb-gitian, tbb-4.5-alpha,
  Browser                |  TorBrowserTeam201504R
   Resolution:           |  Parent ID:
Actual Points:           |
       Points:           |
-------------------------+-------------------------------------------------
Changes (by mcs):

 * status:  needs_review => needs_revision


Comment:

 Kathy and I reviewed these changes.  They look OK, except we think you
 missed un-commenting the final "cd .." within the HTTPS-Everywhere build
 commands in gitian/descriptors/mac/gitian-bundle.yml (the last line
 below):
 {{{
 @@ -103,12 +104,12 @@ script: |
    ~/build/dzip.sh
 ../../../$TORBROWSER_NAME.app/TorBrowser/Data/Browser/profile.default/extensions/torbutton@xxxxxxxxxxxxxxxxxx
 .
    cd ../../../
    #
 -  # cd https-everywhere
 +  cd https-everywhere
    # XXX: Bloody hack to workaround a bug in HTTPS_E's git hash extraction
 in
    # makexpi.sh. See https://trac.torproject.org/projects/tor/ticket/10066
 -  # rm -f .git/refs/heads/master
 -  # ./makexpi.sh
 -  # cp pkg/*.xpi
 ../$TORBROWSER_NAME.app/TorBrowser/Data/Browser/profile.default/extensions
 /https-everywhere@xxxxxxxxxxx
 +  rm -f .git/refs/heads/master
 +  ./makexpi.sh
 +  cp pkg/*.xpi
 ../$TORBROWSER_NAME.app/TorBrowser/Data/Browser/profile.default/extensions
 /https-everywhere@xxxxxxxxxxx
    # cd ..
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15689#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs