[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14716 [Tor Browser]: HTTP Basic Authentication prompt only displayed once

#14716: HTTP Basic Authentication prompt only displayed once
--------------------------+------------------------------------------------
     Reporter:  mcs       |      Owner:  mcs
         Type:  defect    |     Status:  new
     Priority:  normal    |  Milestone:
    Component:  Tor       |    Version:
  Browser                 |   Keywords:  tbb-usability-stoppoint-navigation
   Resolution:            |  Parent ID:
Actual Points:            |
       Points:            |
--------------------------+------------------------------------------------
Changes (by mcs):

 * cc: mikeperry (added)


Comment:

 We decide to make the fixes available (it is almost always better to look
 at code).

 Approach 1 is on the bug14716-loginmgr-01 branch in the brade tor-browser
 repo (https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug14716-loginmgr-01&id=f0fe46bcec5946e94fd66792983b1f081913a74f).

 Note that many of the functions to which we added null checks are not
 called (probably because with these changes getLoginSavingEnabled() will
 return false and countLogins() will return zero, which prevents other code
 from being executed).

 Approach 2 is on the bug14716-loginmgr-01 branch
 (https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug14716-softoken-01&id=27ff6a1f17a006620b092ddc79ed37d9c3e74c35).

 Short and sweet -- but Kathy and I do not understand the surrounding code
 well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14716#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs