[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #13294 [Torsocks]: futex support

#13294: futex support
--------------------------+---------------------------
     Reporter:  Safari    |      Owner:  dgoulet
         Type:  defect    |     Status:  needs_review
     Priority:  normal    |  Milestone:
    Component:  Torsocks  |    Version:
   Resolution:            |   Keywords:  syscall futex
Actual Points:            |  Parent ID:
       Points:            |
--------------------------+---------------------------

Comment (by isis):

 Replying to [comment:4 yawning]:
 > Isis pointed out to me that certain libuv based applications break
 horribly when ran with torsocks.
 >
 > Maybe this is deserving of a separate branch/ticket, but for the record:
 >  * ~~`accept4`~~
 >  * `epoll_create`/~~`epoll_create1`~~
 >  * ~~`epoll_wait`~~/~~`epoll_pwait`~~
 >  * ~~`epoll_ctl`~~
 >  * `eventfd`/~~`eventfd2`~~
 >  * `inotify_init`/~~`inotify_init1`~~
 >  * ~~`inotify_add_watch`~~/~~`inotify_rm_watch`~~
 >  * `pipe2` (Kind of optional, fallback code exists, but it will log
 warnings).
 >
 > I have sort of mixed feelings about this, because I really want to say
 the correct behavior here is, "fix libuv to use the glibc wrappers that
 only the most prehistoric of glibcs won't have".  It's worth noting that
 even with all the required syscalls added (only added the modern
 counterparts when old ones exist), libuv's regression tests still fail
 horribly.
 >
 > Edit: Updated the additional syscalls that my branch handles.

 I reviewed Yawning's patches and have been running with them for about a
 week now. They seem safe, and they fix using several of my applications
 with torsocks, which previously segfaulted or went into endless loops
 (i.e. Julia's REPL, meld).

 Is there any way we could get
 [https://github.com/Yawning/torsocks/compare/linux_syscalls the patches]
 reviewed by a second set of eyes and merged, please?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/13294#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs