[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #14716 [Tor Browser]: HTTP Basic Authentication prompt only displayed once

#14716: HTTP Basic Authentication prompt only displayed once
--------------------------+------------------------------------------------
     Reporter:  mcs       |      Owner:  mcs
         Type:  defect    |     Status:  new
     Priority:  normal    |  Milestone:
    Component:  Tor       |    Version:
  Browser                 |   Keywords:  tbb-usability-stoppoint-navigation
   Resolution:            |  Parent ID:
Actual Points:            |
       Points:            |
--------------------------+------------------------------------------------

Comment (by gk):

 I think we should go with approach 1 which I sort of had in mind for
 #13254 (which somehow dropped from my ToDo list, or better, got pushed
 down on it). Two reasons for this:

 1) I'd guess this has much better chances to get upstreamed. I mean, why
 not checking for `_storage` first before using it? Compared to the NSS
 related fix this might be much less controversial and fixes the issue
 where it occurs.
 2) IMO this would allow us to sneak the patch still into 4.5. While we may
 not know exactly what these checks fix I guess they help a lot and there
 is not much that can go wrong compared to our current state where we
 simply throw and the functionality is broken. Usability ftw!

 To minimize the patch we should only add checks where really needed. I am
 not sure about suppressing the strings yet. I think in the end we want
 what Mozilla is comfortable to merge with but ideally I'd like to avoid
 spamming the error console.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14716#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs