[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]
Re: [tor-bugs] #14716 [Tor Browser]: HTTP Basic Authentication prompt only displayed once
#14716: HTTP Basic Authentication prompt only displayed once
-------------------------+-------------------------------------------------
Reporter: mcs | Owner: mcs
Type: defect | Status: needs_review
Priority: normal | Milestone:
Component: Tor | Version:
Browser | Keywords: tbb-usability-stoppoint-navigation,
Resolution: | tbb-4.5-alpha, TorBrowserTeam201504R
Actual Points: | Parent ID:
Points: |
-------------------------+-------------------------------------------------
Changes (by mcs):
* keywords: tbb-usability-stoppoint-navigation, tbb-4.5-alpha =>
tbb-usability-stoppoint-navigation, tbb-4.5-alpha,
TorBrowserTeam201504R
* status: new => needs_review
Comment:
Replying to [comment:11 brade]:
> Mark and I are looking into a way to suppress the error console message
that we saw.
Unfortunately, it seems that suppressing the Browser Console message that
I mentioned in ticket:14716#comment:9 will be difficult. Minus a few rare
cases, whenever an exception is throw across an XPConnect boundary it is
logged to the Browser Console. See:
http://mxr.mozilla.org/mozilla-
esr31/source/js/xpconnect/src/XPCWrappedJSClass.cpp#891
The good news is that the fix we already have on the bug14716-loginmgr-01
branch within the brade repo appears to fix this ticket as well as #13254
and most of the tickets that were marked as duplicates of that ticket. So
it is a huge improvement, as Georg predicted!
However, I still see the symptoms described in #13926, so that must be
caused by something else or some aspect of nsLoginManager.js that we did
not patch. It takes 5 or 6 cycles of opening and closing the Page Info
window and certificate viewer to produce the problem, which makes it more
difficult to debug.
For TB 4.5, I think we should go ahead and merge the fix we already have,
i.e.,
https://gitweb.torproject.org/user/brade/tor-
browser.git/commit/?h=bug14716-loginmgr-01&id=f0fe46bcec5946e94fd66792983b1f081913a74f
We can pursue an improved fix as part of our ff38-esr efforts.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/14716#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs