[Author Prev][Author Next][Thread Prev][Thread Next][Author Index][Thread Index]

Re: [tor-bugs] #15248 [Tor]: autoconf: drop workarounds for libevent <1.3

#15248: autoconf: drop workarounds for libevent <1.3
-------------------------+-------------------------------------------------
     Reporter:  nickm    |      Owner:
         Type:  defect   |     Status:  needs_review
     Priority:  minor    |  Milestone:  Tor: 0.2.7.x-final
    Component:  Tor      |    Version:
   Resolution:           |   Keywords:  autoconf, libevent,
Actual Points:           |  027-triaged-1-out
       Points:           |  Parent ID:
-------------------------+-------------------------------------------------

Comment (by nickm):

 Replying to [comment:3 yawning]:
 > Looks ok.
 >
 > Should we leave `tor_check_libevent_version()` and the associated
 control event in the code on the off chance that something goes horribly
 wrong in the future?  ("No" is a fine answer, but that's the only place
 that generates `BAD_LIBEVENT` so we should remove it from control-spec.txt
 as well if we take the patch as is.)

 I think it's fine to remove the control event and
 tor_check_libevent_version(); there hasn't been a version that broken in
 use in a long time.

 Removing BAD_LIBEVENT from the spec is a different matter though.  It is
 IMO fine for us to specify that controllers must handle a given error code
 or event, even if it is one that Tor no longer generates.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15248#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs