[tor-bugs] #15782 [Tor]: Correct "longest possible policy" comment in router_parse_addr_policy_item_from_string()

["Tor Bug Tracker & Wiki" <blackhole@xxxxxxxxxxxxxx>]

#15782: Correct "longest possible policy" comment in
router_parse_addr_policy_item_from_string()
--------------------------+------------------------------------
 Reporter:  teor          |          Owner:
     Type:  defect        |         Status:  new
 Priority:  trivial       |      Milestone:  Tor: 0.2.7.x-final
Component:  Tor           |        Version:  Tor: unspecified
 Keywords:  comment-only  |  Actual Points:
Parent ID:                |         Points:
--------------------------+------------------------------------
 The "longest possible policy" comment in
 router_parse_addr_policy_item_from_string() used an example policy that
 was actually shorter than the maximum length.

 This comment was amended, and expanded to count the maximum number of
 characters.

 Comment change only.

 Fixed in:
 '''Branch:''' longest-policy-comment
 '''Repository:''' âhttps://github.com/teor2345/tor.git

 This looks to be a patch on the 2007 code, so who knows what version that
 was, and is it really that important for a comment?

  r15140@catbus:  nickm | 2007-09-18 11:34:54 -0400
  Get rid of a needless malloc() when parsing address policies.  Original
 patch from "Some guy on #tor", via arma.  Altered to have a sufficiently
 large buffer, and not use the buffer so much, and to save a strlcpy.
  svn:r11480

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/15782>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
_______________________________________________
tor-bugs mailing list
tor-bugs@xxxxxxxxxxxxxxxxxxxx
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs